Finish dnf5 CI review and cleanup#1635
Merged
jan-kolarik merged 8 commits intorpm-software-management:mainfrom Feb 18, 2025
Merged
Finish dnf5 CI review and cleanup#1635jan-kolarik merged 8 commits intorpm-software-management:mainfrom
jan-kolarik merged 8 commits intorpm-software-management:mainfrom
Conversation
They are no longer used, this branch is dnf5 only. For dnf4 there is a dnf-4-stack branch.
The dnf5 specification is no longer needed because this branch is only for dnf5. For dnf4 there is dnf-4-stack branch.
These tests were not marked `@dnf5`.
Also removes duplic steps used for specifically using dnf4/dnf5.
dnf4 is handled in a separate branch `dnf-4-stack` of `ci-dnf-stack`.
We run dnf5 tests both when no tag is specified and when `@dnf5` is set. This makes sure all current ci-dnf-stack runs (that can look like: `./container-test run --tags dnf5 --command dnf5`) continue to work. Otherwise no scenarios would run because no tests are marked as `@dnf5`.
Contributor
Author
|
@jan-kolarik this should be ready now. |
jan-kolarik
approved these changes
Feb 18, 2025
Member
jan-kolarik
left a comment
jan-kolarik
left a comment
There was a problem hiding this comment.
Perfect, I didn't went carefully through all the file changes, but in overall the changes look reasonable and tests are passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires: #1633
With this it's no longer necessary to specify the
dnf5tag on each run.